-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Telegram provider #68
Conversation
Pull Request Test Coverage Report for Build 306194037
💛 - Coveralls |
* Separate Telegram API methods into their own interface * Test TelegramHandler and TelegramAPI independently * Update usage example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR. The code is clean, easy to read, and probably does the right thing (I have not tried to run an example yet). I've added some (mostly minor) things to address. And another missing part - some documentation in the README about tg providers.
In worst case we would end up sending 2 extra messages to the user
@umputun Thanks for the feedback! I've fixed things that you have mentioned and added some documentation for the feature (although I'm not sure if it is good enough). |
I have tried to run _example but can't get it to work. Tried to follow the instruction, i.e. registred a new bot, got the token, passed it in, i.e. |
* Fetch bot username on Handler initialization * _example: Do not run tg provider when token is not supplied * Fix docs to reflect changes
@umputun My bad. The bot username in _example was hardcoded, so you were probably sending start command to the wrong bot. Pushing a fix RN. |
thx, worked |
how about this issue? as soon as user logged out, it starts to send those, constantly:
|
Fixed. The requests are now made only after link is clicked to avoid polluting logs. |
LGTM, thx |
Thanks for your time! |
This PR adds Telegram as a login provider. The new flow uses deep-linking (see official example) to establish user identity.
Here are the steps:
TODO:
Closes #49