Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to CLDR v38. Fixes #32. #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bojanz
Copy link
Contributor

@bojanz bojanz commented Nov 6, 2020

This is going to be tough to review. Perhaps it would be easier to do the update in jumps (e.g. v32 -> v34 -> v36 -> v38).

With the newline fix in parseDateTimeFormat() I was able to get the generation process to complete.

However, multiple tests are failing. The most notable ones are for fr*, and for a reason:

func (fr *fr_CA) CardinalPluralRule(num float64, v uint64) locales.PluralRule {

	n := math.Abs(num)
	i := int64(n)
	iMod1000000 := i % 1000000

	if i == 0 || i == 1 {
		return locales.PluralRuleOne
	} else if (e == 0 && i != 0 && iMod1000000 == 0 && v == 0) || (e < 0 || e > 5) {
		return locales.PluralRuleMany
	}

	return locales.PluralRuleOther
}

e is undefined, which means there's another bug in generate_resources.go, most likely in parseCardinalPluralRuleFunc.

@bojanz
Copy link
Contributor Author

bojanz commented Nov 6, 2020

Opened #34 to try and do the update in pieces. Feel free to close it if you prefer the all-at-once-approach. In that case the ru_RU_test.go changes will have to be ported here.

EDIT: Replaced by #35, which gets us up to v36.1.

@rande
Copy link

rande commented Nov 14, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants