RegisterTagNameFunc doc update #1128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deankarn
reviewed
Aug 6, 2023
| @@ -190,7 +190,7 @@ func (v *Validate) ValidateMap(data map[string]interface{}, rules map[string]int | |||
| return v.ValidateMapCtx(context.Background(), data, rules) | |||
| } | |||
|
|
|||
| // RegisterTagNameFunc registers a function to get alternate names for StructFields. | |||
| // RegisterTagNameFunc registers a function to get alternate names (other than sturct field names) from FieldName. | |||
There was a problem hiding this comment.
I don't think this is 100% correct either as if does not get them from FieldName but the reflect.StructField; perhaps it's still not specific enough?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
RegisterTagNameFunc document was misleading. I updated the description to be more clear.
It doesn't affect the strings return from
StructFieldso I added where it affect.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers