Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for github.com/jackc/pgx driver. #139

Merged
merged 1 commit into from Dec 8, 2017
Merged

Add support for github.com/jackc/pgx driver. #139

merged 1 commit into from Dec 8, 2017

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 7, 2017 •
edited

Closes #68.

@AlekSi AlekSi added the feature label Dec 7, 2017
@AlekSi AlekSi added this to the v1.4.0 milestone Dec 7, 2017
@AlekSi AlekSi self-assigned this Dec 7, 2017
@AlekSi AlekSi changed the title Add support for pgx driver Add support for github.com/jackc/pgx driver. Dec 7, 2017
@codecov
Copy link

codecov bot commented Dec 7, 2017 •
edited

Codecov Report

Merging #139 into v1-4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v1-4     #139   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files          19       19           
  Lines        1531     1531           
=======================================
  Hits         1065     1065           
  Misses        416      416           
  Partials       50       50
Impacted Files Coverage Δ
reform-db/main.go 1.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f6d68...edb988a. Read the comment docs.

@AlekSi AlekSi merged commit 82b21b5 into v1-4 Dec 8, 2017
@AlekSi AlekSi deleted the pgx branch December 8, 2017 12:13
AlekseyMartynov
AlekseyMartynov reviewed Dec 8, 2017
View reviewed changes
Copy link
Collaborator

@AlekseyMartynov AlekseyMartynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyMartynov AlekseyMartynov AlekseyMartynov left review comments

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@AlekSi AlekSi

Labels
feature
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlekSi @AlekseyMartynov