Override view name in querier #167

AlekSi · 2018-07-31T07:19:37Z

TODO

More tests.
Support for INSERT/UPDATE/DELETE.

querier_examples_test.go

codecov · 2018-07-31T10:05:43Z

Codecov Report

Merging #167 into v1-stable will increase coverage by 0.18%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v1-stable     #167      +/-   ##
=============================================
+ Coverage       68.4%   68.58%   +0.18%     
=============================================
  Files             19       19              
  Lines           1557     1566       +9     
=============================================
+ Hits            1065     1074       +9     
  Misses           442      442              
  Partials          50       50

Impacted Files	Coverage Δ
querier_selects.go	`97.29% <100%> (+0.07%)`	⬆️
querier.go	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8019070...27faa85. Read the comment docs.

AlekSi · 2018-08-07T04:46:20Z

querier.go

+func (q *Querier) WithView(viewName string) *Querier {
+	newQ := newQuerier(q.dbtx, q.Dialect, q.Logger)
+	newQ.viewName = viewName
+	return newQ


We are losing tag here.

AlekSi · 2018-08-07T04:47:51Z

querier.go

 // QualifiedView returns quoted qualified view name.
 func (q *Querier) QualifiedView(view View) string {
 	v := q.QuoteIdentifier(view.Name())
+	if q.viewName != "" {
+		v = q.QuoteIdentifier(q.viewName)


Uh oh. view parameter is ignored when q.viewName is set.

AlekSi · 2018-08-07T04:48:51Z

reform-db/cmd_init_test.go

@@ -38,7 +38,11 @@ func (s *ReformDBSuite) TestInit() {

 	fis, err := ioutil.ReadDir(dir)
 	s.Require().NoError(err)
-	s.Require().Len(fis, 4)
+	if s.db.Dialect == sqlite3.Dialect {
+		s.Require().Len(fis, 4) // generate 4 struct files for sqlite3


We should use views for SQLite3 too.

querier_selects.go

querier_test.go

querier_examples_test.go

AlekSi · 2018-08-07T06:11:57Z

@bitxel May you please check this branch? It should work for all SELECTs without nasty side-effects.

AlekSi · 2018-08-07T06:13:40Z

querier_selects.go

+		from = q.qualifiedViewName + " AS " + from
+	}
+
+	return fmt.Sprintf("%s %s FROM %s %s", query, strings.Join(q.QualifiedColumns(view), ", "), from, tail)


Here we only change table name in FROM clause and alias it to the old name. That should do the trick for all SELECTs. @bitxel, please check it out.

understand, it's a neat way that only change the view name when making SQL,
but it may lose the schema name, so it's caller's responsibility to add and quote the schema name

querier_test.go

# Conflicts: # querier.go # querier_test.go

go-reform-bot · 2020-07-29T06:47:13Z

querier.go

-// QualifiedView returns quoted qualified view name.
+// WithQualifiedViewName returns a copy of Querier with set qualified view name.
+// Returned Querier is tied to the same DB or TX.
+// TODO Support INSERT/UPDATE/DELETE. More test.


[Optional linters] _{reported by reviewdog 🐶}
querier.go:73: Line contains TODO/BUG/FIXME: "TODO Support INSERT/UPDATE/DELETE. More ..." (godox)

go-reform-bot · 2020-07-29T06:47:13Z

querier_examples_test.go

@@ -85,6 +85,20 @@ func ExampleQuerier_WithContext() {
 	_, _ = DB.WithContext(ctx).SelectAllFrom(ProjectTable, "")
 }

+func ExampleQuerier_WithQualifiedViewName() {
+	_, err := DB.WithQualifiedViewName("people_0").FindByPrimaryKeyFrom(PersonTable, 1)
+	if err != reform.ErrNoRows {


[Optional linters] _{reported by reviewdog 🐶}
err113: do not compare errors directly, use errors.Is() instead: "err != reform.ErrNoRows" (goerr113)

go-reform-bot · 2020-07-29T06:47:13Z

querier_test.go

+		s.Equal(`"people"`, s.q.QualifiedView(PersonTable))
+		s.Equal(`"people"`, s.q.WithQualifiedViewName("ignored").QualifiedView(PersonTable))
+
+	case mssql.Dialect, sqlserver.Dialect:


[Optional linters] _{reported by reviewdog 🐶}
SA1019: mssql.Dialect is deprecated: Use sqlserver.Dialect instead. https://github.com/denisenkom/go-mssqldb#deprecated (staticcheck)

AlekSi added the feature label Jul 31, 2018

AlekSi added this to the v1.4.0 milestone Jul 31, 2018

AlekSi self-assigned this Jul 31, 2018

AlekSi changed the base branch from v1-stable to v1-4 July 31, 2018 07:19

golangci reviewed Jul 31, 2018

View reviewed changes

querier_examples_test.go Outdated Show resolved Hide resolved

This was referenced Jul 31, 2018

Override view name in querier #155

Closed

Include linter name in the review comment golangci/golangci#11

Closed

AlekSi commented Aug 7, 2018

View reviewed changes

golangci reviewed Aug 7, 2018

View reviewed changes

querier_selects.go Show resolved Hide resolved

querier_test.go Show resolved Hide resolved

querier_test.go Show resolved Hide resolved

querier_test.go Show resolved Hide resolved

querier_examples_test.go Show resolved Hide resolved

querier_examples_test.go Show resolved Hide resolved

AlekSi commented Aug 7, 2018

View reviewed changes

AlekSi added help-wanted hacktoberfest labels Oct 7, 2018

AlekSi removed the hacktoberfest label Nov 12, 2018

AlekSi force-pushed the v1-4 branch from de4e9c0 to 8019070 Compare December 11, 2018 07:54

bitxel and others added 3 commits December 12, 2018 19:15

Override view name in querier

db00617

Add better example.

d194063

Fix overriding of view name in Querier.

27faa85

AlekSi force-pushed the bitxel-with-view-name branch from 751abbf to 27faa85 Compare December 12, 2018 16:15

AlekSi closed this Dec 28, 2018

AlekSi changed the base branch from v1-4 to v1-stable December 28, 2018 07:12

AlekSi reopened this Dec 28, 2018

Merge branch 'v1-stable' into bitxel-with-view-name

926b8bc

golangcibot reviewed Aug 10, 2019

View reviewed changes

querier_test.go Show resolved Hide resolved

AlekSi added 3 commits July 5, 2020 13:55

Merge branch 'main' into bitxel-with-view-name

7136079

# Conflicts: # querier.go # querier_test.go

Merge branch 'v1-stable' into bitxel-with-view-name

ea48221

Merge branch 'v1-stable' into bitxel-with-view-name

6d5562e

AlekSi marked this pull request as draft July 16, 2020 18:33

Merge branch 'v1-stable' into bitxel-with-view-name

dd045aa

AlekSi modified the milestones: v1.4.0, v1.5.0 Jul 19, 2020

AlekSi changed the base branch from v1-stable to main July 19, 2020 11:52

Merge branch 'main' into bitxel-with-view-name

d517892

go-reform-bot reviewed Jul 29, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Override view name in querier #167

Override view name in querier #167

AlekSi commented Jul 31, 2018 •

edited

codecov bot commented Jul 31, 2018 •

edited

AlekSi Aug 7, 2018

AlekSi Aug 7, 2018

AlekSi Aug 7, 2018

AlekSi commented Aug 7, 2018

AlekSi Aug 7, 2018

bitxel Aug 26, 2018

go-reform-bot Jul 29, 2020

go-reform-bot Jul 29, 2020

go-reform-bot Jul 29, 2020

Override view name in querier #167

Are you sure you want to change the base?

Override view name in querier #167

Conversation

AlekSi commented Jul 31, 2018 • edited

codecov bot commented Jul 31, 2018 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekSi commented Aug 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlekSi commented Jul 31, 2018 •

edited

codecov bot commented Jul 31, 2018 •

edited