Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for PostgreSQL 14 #11

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Add tests for PostgreSQL 14 #11

merged 1 commit into from
Oct 29, 2021

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 28, 2021

  • Add tests for jackc/pgx driver
  • Update readme

@lafriks lafriks added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021 •
edited
Loading

Codecov Report

Merging #11 (36480ce) into main (94abfa7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          127       127           
=========================================
  Hits           127       127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94abfa7...36480ce. Read the comment docs.

@lafriks
Copy link
Contributor Author

lafriks commented Oct 28, 2021

I will rebase once #10 is merged to reuse AdapterSpecs func in pgx tests

@lafriks
Add tests for PostgreSQL 14
36480ce 
* Add tests for jackc/pgx driver
@lafriks
Copy link
Contributor Author

lafriks commented Oct 29, 2021

Rebased

@lafriks lafriks requested a review from Fs02 October 29, 2021 07:57
Fs02
Fs02 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@Fs02 Fs02 merged commit 873dc18 into go-rel:main Oct 29, 2021
@lafriks lafriks deleted the feat/postgres14 branch October 29, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lafriks @Fs02