Implement adapter Name and add Name constant #65
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 127 130 +3
=========================================
+ Hits 127 130 +3
☔ View full report in Codecov by Sentry. |
|
Ready for review Coverage can not check panic in MustOpen because db.Open never returns error so not much to be done there :/ At least I could not get it to return error, even for invalid dsn |
|
can you do similar to this? so panic can be tested separately |
|
I don't really see much point in this as this only gives sense of coverage but does not actually test specific case |
…es server versions
|
Ok, I think I found a better way to actually make MustOpen to get error and panic so this can be tested now. On a side note it's now possible to use Open and MustOpen functions also with pgx drivers |
|
@Fs02 gentle ping :) |
| // Identify if pgx driver is available and default to that instead. | ||
| for _, drv := range db.Drivers() { | ||
| if drv == "pgx" { | ||
| driverName = "pgx" |
There was a problem hiding this comment.
nit: (maybe not in this PR) I think we should provide a way to override this behavior? such as explicitly setting the driver name?
There was a problem hiding this comment.
Thought about that but as there are currently no more options I did not do this
|
@Fs02 fixed review comment |
Depends on go-rel/primaryreplica#28