Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement adapter Name for internal tests #59

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Implement adapter Name for internal tests #59

merged 4 commits into from
Nov 6, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 16, 2023 •
edited
Loading

Closes #63

@lafriks lafriks requested a review from Fs02 October 16, 2023 10:16
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57a6cca) 100.00% compared to head (5c649a2) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1444      1444           
=========================================
  Hits          1444      1444
Files Coverage Δ
nop_adapter.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lafriks lafriks added the dependencies Pull requests that update a dependency file label Oct 17, 2023
Fs02
Fs02 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Fs02
Copy link
Member

Fs02 commented Oct 28, 2023

can you fix the conflict? thanks

@lafriks
Copy link
Contributor Author

lafriks commented Nov 5, 2023

conflict resolved

Fs02
Fs02 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Fs02 Fs02 merged commit 0809a3c into go-rel:main Nov 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lafriks @Fs02