Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default adapter Name implementation #59

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Add default adapter Name implementation #59

merged 3 commits into from
Oct 7, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 3, 2023

Depends on go-rel/rel#346

@lafriks lafriks added the enhancement New feature or request label Oct 3, 2023
This was referenced Oct 3, 2023
Merged
Open
@lafriks lafriks changed the title Add default adapter DBType implementation Add default adapter Name implementation Oct 7, 2023
@lafriks lafriks marked this pull request as ready for review October 7, 2023 12:37
@lafriks
Copy link
Contributor Author

lafriks commented Oct 7, 2023

Ready to review, after this all adapters can be updated

@lafriks lafriks requested a review from Fs02 October 7, 2023 15:39
Fs02
Fs02 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fs02 Fs02 merged commit be5e6ac into go-rel:main Oct 7, 2023
2 checks passed
@lafriks lafriks deleted the feat/adapter_dbtype branch October 7, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fs02 Fs02 Fs02 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lafriks @Fs02