Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type helper for low-level cdp request #19

Closed
ysmood opened this issue May 1, 2020 · 0 comments
Closed

Type helper for low-level cdp request #19

ysmood opened this issue May 1, 2020 · 0 comments
Assignees
Labels
enhance New feature or request

Comments

@ysmood
Copy link
Member

ysmood commented May 1, 2020

We don't need full type support, a better way to do it is to add optional type helper to help us type the json objects that chrome uses.

By this optional way, the user can still interact with the latest chrome API even if the type helper is outdated.

The schema to use is on this page: GET /json/protocol/

The way https://github.com/mafredri/cdp or https://github.com/chromedp/chromedp did it is not good enough. Their implementations are tightly coupled with their high-level lib. Therefore their type is hard to be used as a standalone lib when someone only wants to use the type to generate a request JSON payload.

@ysmood ysmood added the enhance New feature or request label May 1, 2020
@ysmood ysmood self-assigned this May 1, 2020
ysmood added a commit that referenced this issue May 6, 2020
ysmood added a commit that referenced this issue May 6, 2020
ysmood added a commit that referenced this issue May 8, 2020
@ysmood ysmood closed this as completed in e03c9cb May 11, 2020
ysmood added a commit that referenced this issue May 11, 2020
ysmood added a commit that referenced this issue May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant