Add cache observer #766
Merged
Add cache observer #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not had a chance to test the push on this. So, this is not quite ready. |
Pull Request Test Coverage Report for Build d74533b06-PR-766
💛 - Coveralls |
ARolek
reviewed
Mar 30, 2021
gdey
force-pushed
the
add_cache_observer
branch
3 times, most recently
from
78596f7
to
867cd29
Compare
Split out the Observability interface so that API route and viewer route are dealt with separately. Moved Null Observer to an internal package, treating nil as a Null Observer. Prometheus observer can be configured to indicate which API vars should be filled in. Default variables are :map_name, :layer_name and :z.
Moved build information into an internal package to make it simpler to set and share that information across various packages.
Includes support for pushing, and the pushing will happen at an interval which defaults to 10 seconds. * Added cleanup for Observability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Observability metrics for Cache Providers.
This will work for all providers.
Includes support for push.
fixes #756