-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: safe funcs, follow go template standards and sprout conventions #65
Conversation
Documentation are updated : https://docs.atom.codes/sprout/~/changes/1eETtqCYtVeEPVLnbGs0?r=W7cRL8cXHka2XCuOcvBs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed a part of your changes yet
You should consider running testifylint on your codebase. You can enable it via golangci-lint |
628fabf
to
d49eeba
Compare
hi @ccoVeille, review returns done, one discussion stay open to let you read and react : #65 (comment) Thanks for your time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but a few suggestion anyway
Co-Authored-By: ccoVeille <3875889+ccoVeille@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
|
Description
This pull request updates all signatures to follow Go template standards and Sprout conventions, and add the
safe
behavior for functions instead of must as discussed on #32Important
The signature changes do not introduce breaking changes. A deprecation notice will be displayed instead.
Two types of warn :
Note
This will spam the logger but will inform and prevent any breaking changes in the code. The signature migrations are encapsulated by banners in the codebase to avoid missing them when we remove the old signatures.
Documentation are available here : https://docs.atom.codes/sprout/~/changes/1eETtqCYtVeEPVLnbGs0?r=W7cRL8cXHka2XCuOcvBs
Checklist
Additional Information