Return ErrBadCon when buffer is in wrong state during interpolation

[pfreixes]

Description

We are trying to address the bug reported here #1542 where we explicitly mark the connection in invalid state which should trigger two events, the removal of the connection from the pool and having another one created, and if configured a retry.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

Summary by CodeRabbit

• Refactor
  • Improved error handling for connection issues by shifting to a more standardized error response.

[coderabbitai]

Walkthrough

The change focuses on enhancing error handling for connection issues in a Go project by modifying the error type returned during certain failure conditions. Specifically, it involves updating the error response to a more appropriate type that reflects issues with unhealthy TCP connections, aiming to improve the management and recycling of connections within the application.

Changes

File(s)	Change Summary
connection.go	Replaced ErrInvalidConn with driver.ErrBadConn to better indicate connection issues.

Related issues

• Likely race that can prevent to recycle closed connections #1542: This issue discusses the problems related to "invalid connection" errors after upgrading the MySQL client and considers the semantic correctness of the error returned. The change to return driver.ErrBadConn instead of ErrInvalidConn directly addresses the concerns raised, making it a candidate for linking to this PR. The reasoning is the alignment in objectives regarding the improvement of connection error handling and the potential to resolve TCP connection issues more effectively.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 743e263 and 6b6ce1e.

Files selected for processing (1)

• connection.go (1 hunks)

Additional comments: 1

connection.go (1)

• 212-214: The change from returning a generic error to driver.ErrBadConn in the interpolateParams function is aligned with the PR's objective to improve error handling by marking connections as invalid appropriately. This change ensures that the SQL driver's connection pool management can take necessary actions like removing the faulty connection and potentially retrying the operation with a new connection if supported.

[coveralls]

coverage: 82.149% (-0.02%) from 82.17%
when pulling 6b6ce1e on pfreixes:fix_error_interpolation
into 743e263 on go-sql-driver:master.

[methane]

I need to learn how to use ErrBadConn/ErrInvalidConn/errBadConnNoWrite correctly.
Please wait.