Add deadline for connection #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhiFeng Hu <hufeng1987@gmail.com>
| @@ -71,6 +72,9 @@ func (d MySQLDriver) Open(dsn string) (driver.Conn, error) { | |||
|
|
|||
| // Enable TCP Keepalives on TCP connections | |||
| if tc, ok := mc.netConn.(*net.TCPConn); ok { | |||
| timeout := time.Now().Add(mc.cfg.timeout) | |||
| tc.SetReadDeadline(timeout) | |||
| tc.SetDeadline(timeout) | |||
There was a problem hiding this comment.
It's total bad place to set deadline.
Additionaly, why do you set both of ReadDeadline and Deadline?
There was a problem hiding this comment.
Control the timeout. if connection broken. exit early. then we can reconnect again.
There was a problem hiding this comment.
Have you really tested your code?
ghost
closed this
|
I had tested for my production apps. thanks for your attentions. i choose to close this pr. sorry for any uncomfortable noise. |
|
I think #372 is what you want to do. |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#375
#392
Signed-off-by: ZhiFeng Hu hufeng1987@gmail.com