Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decimal for sql execution. #986

Closed
wants to merge 2 commits into from
Closed

Support decimal for sql execution. #986

wants to merge 2 commits into from

Conversation

caeret
Copy link

@caeret caeret commented Aug 1, 2019

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member

methane commented Aug 1, 2019

I don't like it. It doesn't true decimal support.
It is just pass the string without escaping or quoting.
Essencially, it is same to fmt.Sprintf, but far complicated and poor performance.

@caeret
Copy link
Author

caeret commented Aug 15, 2019

@methane I updated the code implementation.

@methane
Copy link
Member

methane commented Nov 8, 2019

It doesn't make sense at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants