Replace tylerb/graceful with inbuilt methods Go 1.8 onwards - new request #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
==========================================
- Coverage 74.9% 74.79% -0.11%
==========================================
Files 37 37
Lines 7201 7210 +9
==========================================
- Hits 5394 5393 -1
- Misses 1347 1357 +10
Partials 460 460
Continue to review full report at Codecov.
|
|
I think your templates are using spaces instead of tabs or something, the indentation is off compared to the rest of the file |
casualjim
approved these changes
Jun 14, 2018
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Jul 29, 2018
* Avoids panic when certificate or key passed is invalid * Checks that CA certificate passed is correctly parsed Acknowledges the following fixes from previous PR (go-swagger#1627): * fixes go-swagger#1473 * fixes go-swagger#1558 * fixes go-swagger#1473 * fixes go-swagger#1418 (from PR go-swagger#1574) NOTE: fixes are acknowledged using a test script which reproduce the issues. However, this script has not been included in the CI suite.
This was referenced Jul 29, 2018
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Aug 1, 2018
* Avoids panic when certificate or key passed is invalid * Checks that CA certificate passed is correctly parsed Acknowledges the following fixes from previous PR (go-swagger#1627): * fixes go-swagger#1473 * fixes go-swagger#1558 * fixes go-swagger#1418 (from PR go-swagger#1574) NOTE: fixes are acknowledged using a test script which reproduces these issues. However, this script has not been included in the CI suite.
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Aug 3, 2018
* Avoids panic when certificate or key passed is invalid * Checks that CA certificate passed is correctly parsed Acknowledges the following fixes from previous PR (go-swagger#1627): * fixes go-swagger#1473 * fixes go-swagger#1558 * fixes go-swagger#1418 (from PR go-swagger#1574) NOTE: fixes are acknowledged using a test script which reproduces these issues. However, this script has not been included in the CI suite.
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Aug 3, 2018
* Avoids panic when certificate or key passed is invalid * Checks that CA certificate passed is correctly parsed Acknowledges the following fixes from previous PR (go-swagger#1627): * fixes go-swagger#1473 * fixes go-swagger#1558 * fixes go-swagger#1418 (from PR go-swagger#1574) NOTE: fixes are acknowledged using a test script which reproduces these issues. However, this script has not been included in the CI suite.
fredbi
added a commit
to fredbi/go-swagger
that referenced
this pull request
Aug 9, 2018
* Avoids panic when certificate or key passed is invalid * Checks that CA certificate passed is correctly parsed Acknowledges the following fixes from previous PR (go-swagger#1627): * fixes go-swagger#1473 * fixes go-swagger#1558 * fixes go-swagger#1418 (from PR go-swagger#1574) NOTE: fixes are acknowledged using a test script which reproduces these issues. However, this script has not been included in the CI suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New request in place of #1494 which will be closed.