urlbuilder template fixed to support query params named 'append' #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes there are many codegen assertions in CI. So you have to scan tests in generator to find out when urlbuilder template is tested. |
|
Do I need to generate the bindata.go before putting up the pull request. I was under the impression that git hooks would take care of that. Is that correct? |
|
yes they normally do, but it seems that in this case it did not work. We use bindata from Kevin Burke's fork. |
fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com>
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 80.81% 80.65% -0.17%
==========================================
Files 38 38
Lines 7627 7645 +18
==========================================
+ Hits 6164 6166 +2
- Misses 973 990 +17
+ Partials 490 489 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 80.81% 80.65% -0.17%
==========================================
Files 38 38
Lines 7627 7645 +18
==========================================
+ Hits 6164 6166 +2
- Misses 973 990 +17
+ Partials 490 489 -1
Continue to review full report at Codecov.
|
|
Any thoughts on where I should go from here? I believe that coverage decrease was due to the bindata.go regeneration. Actually, are we expecting the number of changes in bindata.go based on the change I made to the templates? I used Kevin Burkes go-bindata (master) as recommended. |
|
Codecov is not a required check so don't worry: it is obvious the bindata is causing this. Looks like we haven't regenerated for quite a while... |
fredbi
approved these changes
May 24, 2019
wjase
pushed a commit
to wjase/go-swagger
that referenced
this pull request
Jun 1, 2019
…swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au>
wjase
pushed a commit
to wjase/go-swagger
that referenced
this pull request
Jun 1, 2019
…swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com>
wjase
pushed a commit
to wjase/go-swagger
that referenced
this pull request
Jun 5, 2019
…swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <>
wjase
pushed a commit
to wjase/go-swagger
that referenced
this pull request
Jun 5, 2019
…swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <>
wjase
pushed a commit
to wjase/go-swagger
that referenced
this pull request
Jun 5, 2019
…swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au>
fredbi
pushed a commit
that referenced
this pull request
Jun 20, 2019
* x-go-type: if no imports are specified, assume that the referred type is inside the same package Signed-off-by: Emil Nikolov <emil.e.nikolov@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * support keep spec properties order Signed-off-by: Efi-Kofler <efi.kofler@tectonic.network> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added diff sub command Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored location node code. Detected reponse and param header changes Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated test fixtures Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed redundant method and fixed default/required on response headers Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * urlbuilder template fixed to support query params named 'append' (#1949) fixes #1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored type names and removed some dead code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored analyser and diff code in prep for ignore processing Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to igore selected diffs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to ignore deprecated operations Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added docs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo compatabilty -> compatibilty Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo and scopelint issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * scan: proper parse for numeric elements (future validation pass). Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fix test Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> fix building Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> review: goconst Signed-off-by: d7561985 <d7561985@gmail.com> update Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> add const for linter Signed-off-by: d7561985 <d7561985@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added gocrest in various spots Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updating vendor folder and adding coverage.txt to gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Lower-cased error - lint warning Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated go.mod Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files nuked by rogue gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files lost due to bad gitignore Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated readme Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated README Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Adding lost code and new tests Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated ignore diff test Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Circle CI closed some issues Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated lint settings as recommended by reviewer Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated capitalisation of global Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran go gmt as asked Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed loop scope issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed yet more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran goimports Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * nuked spurious warning from dupl Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed dead code and added an array diff test Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Resolved code suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Cleaning code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * moved test code into diff package to improve coverage report Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed lint suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added kitchensink to diff fictures to improve coverage and fixed the bugs the new test cases detected ;-) Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Improving formatting and coverage at the same time Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Fixed cicd issues Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test for map diff Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Removed dead code Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added empty arg error test Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test cases to get above 80% coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added extra test permutations to boost coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com>
djgilcrease
pushed a commit
to djgilcrease/go-swagger
that referenced
this pull request
Jun 25, 2019
* x-go-type: if no imports are specified, assume that the referred type is inside the same package Signed-off-by: Emil Nikolov <emil.e.nikolov@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * support keep spec properties order Signed-off-by: Efi-Kofler <efi.kofler@tectonic.network> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added diff sub command Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored location node code. Detected reponse and param header changes Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated test fixtures Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed redundant method and fixed default/required on response headers Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * urlbuilder template fixed to support query params named 'append' (go-swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored type names and removed some dead code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored analyser and diff code in prep for ignore processing Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to igore selected diffs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to ignore deprecated operations Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added docs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo compatabilty -> compatibilty Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo and scopelint issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * scan: proper parse for numeric elements (future validation pass). Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fix test Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> fix building Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> review: goconst Signed-off-by: d7561985 <d7561985@gmail.com> update Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> add const for linter Signed-off-by: d7561985 <d7561985@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added gocrest in various spots Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updating vendor folder and adding coverage.txt to gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Lower-cased error - lint warning Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated go.mod Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files nuked by rogue gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files lost due to bad gitignore Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated readme Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated README Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Adding lost code and new tests Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated ignore diff test Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Circle CI closed some issues Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated lint settings as recommended by reviewer Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated capitalisation of global Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran go gmt as asked Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed loop scope issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed yet more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran goimports Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * nuked spurious warning from dupl Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed dead code and added an array diff test Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Resolved code suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Cleaning code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * moved test code into diff package to improve coverage report Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed lint suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added kitchensink to diff fictures to improve coverage and fixed the bugs the new test cases detected ;-) Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Improving formatting and coverage at the same time Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Fixed cicd issues Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test for map diff Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Removed dead code Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added empty arg error test Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test cases to get above 80% coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added extra test permutations to boost coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com>
djgilcrease
pushed a commit
to djgilcrease/go-swagger
that referenced
this pull request
Jun 26, 2019
* x-go-type: if no imports are specified, assume that the referred type is inside the same package Signed-off-by: Emil Nikolov <emil.e.nikolov@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * support keep spec properties order Signed-off-by: Efi-Kofler <efi.kofler@tectonic.network> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added diff sub command Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored location node code. Detected reponse and param header changes Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated test fixtures Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed redundant method and fixed default/required on response headers Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * urlbuilder template fixed to support query params named 'append' (go-swagger#1949) fixes go-swagger#1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored type names and removed some dead code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored analyser and diff code in prep for ignore processing Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to igore selected diffs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to ignore deprecated operations Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added docs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo compatabilty -> compatibilty Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo and scopelint issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * scan: proper parse for numeric elements (future validation pass). Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fix test Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> fix building Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> review: goconst Signed-off-by: d7561985 <d7561985@gmail.com> update Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> add const for linter Signed-off-by: d7561985 <d7561985@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added gocrest in various spots Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updating vendor folder and adding coverage.txt to gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Lower-cased error - lint warning Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated go.mod Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files nuked by rogue gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files lost due to bad gitignore Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated readme Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated README Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Adding lost code and new tests Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated ignore diff test Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Circle CI closed some issues Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated lint settings as recommended by reviewer Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated capitalisation of global Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran go gmt as asked Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed loop scope issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed yet more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran goimports Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * nuked spurious warning from dupl Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed dead code and added an array diff test Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Resolved code suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Cleaning code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * moved test code into diff package to improve coverage report Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed lint suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added kitchensink to diff fictures to improve coverage and fixed the bugs the new test cases detected ;-) Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Improving formatting and coverage at the same time Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Fixed cicd issues Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test for map diff Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Removed dead code Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added empty arg error test Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test cases to get above 80% coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added extra test permutations to boost coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
fredbi
pushed a commit
that referenced
this pull request
Jun 27, 2019
* do not force set the api logger to log.Printf the logger already defaults so do not force set it in `SetAPI` since that would overwrite one I set in the API before calling `SetAPI` Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Add CodeTriage badge to go-swagger/go-swagger Adds a badge showing the number of people helping this repo on CodeTriage. [](https://www.codetriage.com/go-swagger/go-swagger) ## What is CodeTriage? CodeTriage is an Open Source app that is designed to make contributing to Open Source projects easier. It works by sending subscribers a few open issues in their inbox. If subscribers get busy, there is an algorithm that backs off issue load so they do not get overwhelmed [Read more about the CodeTriage project](https://www.codetriage.com/what). ## Why am I getting this PR? Your project was picked by the human, @schneems. They selected it from the projects submitted to https://www.codetriage.com and hand edited the PR. How did your project get added to [CodeTriage](https://www.codetriage.com/what)? Roughly over 3 years ago, [tamarabartlett](https://github.com/tamarabartlett) added this project to CodeTriage in order to start contributing. Since then, 13 people have subscribed to help this repo. ## What does adding a badge accomplish? Adding a badge invites people to help contribute to your project. It also lets developers know that others are invested in the longterm success and maintainability of the project. You can see an example of a CodeTriage badge on these popular OSS READMEs: - [](https://www.codetriage.com/rails/rails) https://github.com/rails/rails - [](https://www.codetriage.com/crystal-lang/crystal) https://github.com/crystal-lang/crystal ## Have a question or comment? While I am a bot, this PR was manually reviewed and monitored by a human - @schneems. My job is writing commit messages and handling PR logistics. If you have any questions, you can reply back to this PR and they will be answered by @schneems. If you do not want a badge right now, no worries, close the PR, you will not hear from me again. Thanks for making your project Open Source! Any feedback is greatly appreciated. Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Fix basic auth for stratoscale template Use the correct signature for the basic authentication interface. This caused the compilation to fail. Fixes #1765 Signed-off-by: Joakim Soderberg <joakim.soderberg@gmail.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Multiple tags operations: deduce package from first tag as for only-one-tag operations, instead of default "operations" as when no tags are available. Signed-off-by: Maxime Soulé <btik-git@scoubidou.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * keep spec order on nested objects Signed-off-by: kofler <efi.kofler@flir.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * chore(ci): set codecov patch expectation to a fixed level, exclude bindata.go from coverage Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * chore(ack): acknowledges fix for #1490 (client w/ body as interface{}) fixes #1490 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * chore(ack): acknowledges fix for #973 (client w/ param UUID) * fixes #973 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * 151 add a diff sub command (#1961) * x-go-type: if no imports are specified, assume that the referred type is inside the same package Signed-off-by: Emil Nikolov <emil.e.nikolov@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * support keep spec properties order Signed-off-by: Efi-Kofler <efi.kofler@tectonic.network> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added diff sub command Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored location node code. Detected reponse and param header changes Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated test fixtures Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed redundant method and fixed default/required on response headers Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * urlbuilder template fixed to support query params named 'append' (#1949) fixes #1948 Update urlbuilder_test.go to support added query name mangling. Update bindata.go Signed-off-by: Jim Turnquist <jim@boonlogic.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored type names and removed some dead code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Refactored analyser and diff code in prep for ignore processing Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to igore selected diffs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added ability to ignore deprecated operations Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added docs Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo compatabilty -> compatibilty Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Fixed typo and scopelint issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * scan: proper parse for numeric elements (future validation pass). Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fix test Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> fix building Signed-off-by: Dzmitry.Harupa <dzmitry.harupa@1pt.com> review: goconst Signed-off-by: d7561985 <d7561985@gmail.com> update Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> test fix Signed-off-by: d7561985 <d7561985@gmail.com> add const for linter Signed-off-by: d7561985 <d7561985@gmail.com> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added gocrest in various spots Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updating vendor folder and adding coverage.txt to gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Lower-cased error - lint warning Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated go.mod Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files nuked by rogue gitignore Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added files lost due to bad gitignore Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated readme Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated README Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Adding lost code and new tests Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated ignore diff test Signed-off-by: Jason Wraxall <> Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Circle CI closed some issues Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated lint settings as recommended by reviewer Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Updated capitalisation of global Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran go gmt as asked Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed loop scope issue Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed yet more formatting Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * ran goimports Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * nuked spurious warning from dupl Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Removed dead code and added an array diff test Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Resolved code suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Cleaning code Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * moved test code into diff package to improve coverage report Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * fixed lint suggestion Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Added kitchensink to diff fictures to improve coverage and fixed the bugs the new test cases detected ;-) Signed-off-by: Jason Wraxall <wjase@yahoo.com.au> * Improving formatting and coverage at the same time Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Fixed cicd issues Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test for map diff Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Removed dead code Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added empty arg error test Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added test cases to get above 80% coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> * Added extra test permutations to boost coverage Signed-off-by: Jason Wraxall <jwraxall@tyro.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * chore(ack): acknowledges fix for #1020 (client w/ param File) fixes #1020 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Acknowlegde #1339 was fixed (generated client w/ binary param) Fixes #1339 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * fixes #1878 (conflicting output options in CLI) Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * doc: updated CLI usage, including the newly added diff command Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Added support for non-standard http codes (#1980) * fixes #1893 * codegen (client and server) now supports codes other than the well-known ones published by go-openapi/runtime Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * fix(server): generates server to enable http/2 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Generated client: handles unexpected successful responses and returns default response with error rather than panicking (#1978) Fixes #1518 Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Honour JSON ,string directive of ptr field when generating spec Signed-off-by: wych42 <wych101010@gmail.com> Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * do not force set the api logger to log.Printf the logger already defaults so do not force set it in `SetAPI` since that would overwrite one I set in the API before calling `SetAPI` Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com> * Regenerate bindata Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
](https://www.codetriage.com/go-swagger/go-swagger){kind=link}
](https://www.codetriage.com/rails/rails){kind=link}
](https://www.codetriage.com/crystal-lang/crystal){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1948
Update urlbuilder_test.go to support added query name mangling.
Signed-off-by: Jim Turnquist jim@boonlogic.com