Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: made codegen-nonreg.sh script less sensitive to merge conflicts #1983

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

fredbi
Copy link
Contributor

@fredbi fredbi commented Jun 23, 2019

Signed-off-by: Frederic BIDON fredbi@yahoo.com

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #1983 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   80.93%   80.93%           
=======================================
  Files          47       47           
  Lines        8060     8060           
=======================================
  Hits         6523     6523           
  Misses       1042     1042           
  Partials      495      495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60799a0...8885894. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d6b79e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1983   +/-   ##
=========================================
  Coverage          ?   80.33%           
=========================================
  Files             ?       46           
  Lines             ?     8167           
  Branches          ?        0           
=========================================
  Hits              ?     6561           
  Misses            ?     1100           
  Partials          ?      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b79e0...d7706fb. Read the comment docs.

@fredbi fredbi force-pushed the fix-merging-issues-codegen-ci branch from 8885894 to 6eb8efa Compare June 27, 2019 18:58
@fredbi
Copy link
Contributor Author

fredbi commented Jun 28, 2019

This is just a technical change in the CI script to ease a bit merge issues when rebasing PR which add some new specs to the global codegen build test.

@fredbi fredbi force-pushed the fix-merging-issues-codegen-ci branch 2 times, most recently from b751ca0 to 4555a98 Compare July 4, 2019 09:40
@casualjim
Copy link
Member

There is a merge conflict here that I'm not sure how to resolve

@fredbi
Copy link
Contributor Author

fredbi commented Jul 4, 2019

@casualjim I'll merge this last.
Anyway, while doing this, I have been considering some larger CI undertaking: I'd wish to replace this ugly shell script by a golang test commander, which we could more easily parallelize. What do you think of https://godoc.org/gotest.tools/icmd ?

@casualjim
Copy link
Member

fine by me

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi force-pushed the fix-merging-issues-codegen-ci branch from 4555a98 to d7706fb Compare July 4, 2019 19:22
@fredbi fredbi merged commit 554756d into go-swagger:master Jul 4, 2019
@fredbi fredbi deleted the fix-merging-issues-codegen-ci branch July 9, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants