Change strfmt.DateTime and strfmt.Date types to alias #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make consistent to strfmt.Duration type. Closes go-swagger#205. But breaks strfmt.DateTime and strfmt.Date use, see strfmt/date_test.go and strfmt/time_test.go. Signed-off-by: Aleksandr Vinokurov <aleksandr.vin@gmail.com>
aleksandr-vin
force-pushed
the
205-unhide-TextMarshaler-and-TextUnmarshaler-interfaces
branch
from
b9c663b
to
7e3946e
Compare
|
After adding missed fixes to tests, all seems to be ok |
|
|
casualjim
added a commit
that referenced
this pull request
Jan 13, 2016
…nd-TextUnmarshaler-interfaces Change strfmt.DateTime and strfmt.Date types to alias
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make consistent to strfmt.Duration type.
Closes #205.
Signed-off-by: Aleksandr Vinokurov aleksandr.vin@gmail.com
