Fix overwriting security definitions on call Server.SetAPI() #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
=======================================
Coverage 80.11% 80.11%
=======================================
Files 47 47
Lines 8254 8254
=======================================
Hits 6613 6613
Misses 1122 1122
Partials 519 519Continue to review full report at Codecov.
|
Signed-off-by: v.votinov <v.votinov@xsolla.com>
h0mjam
force-pushed
the
fix-overwrite-secutiry-definition
branch
from
8ca9ed5
to
2ad3fba
Compare
|
can you run |
Signed-off-by: v.votinov <v.votinov@xsolla.com>
h0mjam
force-pushed
the
fix-overwrite-secutiry-definition
branch
from
5074009
to
ecce65d
Compare
|
Done |
|
@casualjim, hi! Can review PR? |
fredbi
requested changes
Dec 25, 2019
h0mjam
force-pushed
the
fix-overwrite-secutiry-definition
branch
from
c95771e
to
e6acd6c
Compare
fredbi
approved these changes
Dec 26, 2019
|
@h0mjam we are just a commit signature away... Hang on, this all looks good to me. |
Signed-off-by: v.votinov <v.votinov@xsolla.com>
h0mjam
force-pushed
the
fix-overwrite-secutiry-definition
branch
from
e6acd6c
to
f4d5867
Compare
casualjim
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On call Server.SetAPI() trigger internal function configureAPI() which is overwrite above defined (into api object) secirutyDefinitions