refactored code generator #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2177 +/- ##
==========================================
+ Coverage 80.51% 81.04% +0.53%
==========================================
Files 48 49 +1
Lines 8309 8305 -4
==========================================
+ Hits 6690 6731 +41
+ Misses 1103 1075 -28
+ Partials 516 499 -17
Continue to review full report at Codecov.
|
fredbi
force-pushed
the
refactor-spec-loading
branch
6 times, most recently
from
f7d004c
to
956de91
Compare
casualjim
approved these changes
Jan 26, 2020
NO BEHAVIOR CHANGE EXPECTED * removed some (most) redundant code (left redundancies that would introduce change in behavior to forthcoming PRs) * factorized spec loading/validating/flattening operations (new spec.go file) * regrouped state init() function calls * reduced the number of global vars and replaced them by functions * adapted template repo to initialize from language options, with adequate template FuncMap * made DefaultLanguage a configurable function * moved global golang-specific function to LangueOpts (new language.go file) * testability: functionalized a number of hard to test code (e.g. all funcmap entries), and introduced unit testing * started, but did not complete yet the rewriting of unit tests using 'require' instead of nested constructs with 'assert' Signed-off-by: Frederic BIDON <fredbi@yahoo.com> Fixed tests on windows Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
refactor-spec-loading
branch
from
956de91
to
3683004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO BEHAVIOR CHANGE EXPECTED
removed some (most) redundant code (left redundancies that would introduce change in behavior to forthcoming PRs)
factorized spec loading/validating/flattening operations (new spec.go file)
regrouped state init() function calls
reduced the number of global vars and replaced them by functions
adapted template repo to initialize from language options, with adequate template FuncMap
made DefaultLanguage a configurable function
moved global golang-specific function to LangueOpts (new language.go file)
testability: functionalized a number of hard to test code (e.g. all funcmap entries), and introduced unit testing
started, but did not complete yet the rewriting of unit tests using 'require' instead of nested constructs with 'assert'
Signed-off-by: Frederic BIDON fredbi@yahoo.com