Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports of external types, when used as dependency in properties, items, etc #2341

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

fredbi
Copy link
Contributor

@fredbi fredbi commented Jul 6, 2020

Fixed imports of external types in models or inline operations when the external type is part of an inner construct (properties, items, etc).

Signed-off-by: Frederic BIDON fredbi@yahoo.com

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #2341 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2341      +/-   ##
==========================================
+ Coverage   82.11%   82.13%   +0.01%     
==========================================
  Files          50       50              
  Lines        8557     8564       +7     
==========================================
+ Hits         7027     7034       +7     
  Misses       1032     1032              
  Partials      498      498              
Impacted Files Coverage Δ
generator/structs.go 79.13% <ø> (ø)
generator/model.go 85.18% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea5488...2fabbd8. Read the comment docs.

… items, etc

* fixes go-swagger#1897

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@fredbi fredbi changed the title fix imports of external types, when used as dependency in properties,… fix imports of external types, when used as dependency in properties, items, etc Jul 8, 2020
@fredbi fredbi marked this pull request as ready for review July 8, 2020 11:31
@fredbi fredbi merged commit 8644100 into go-swagger:master Jul 8, 2020
@fredbi fredbi deleted the fix-1897 branch July 8, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models not importing x-go-type for one of properties
1 participant