Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task does not follow directory symlinks when checking for dependencies #826

Closed
mbergal opened this issue Aug 3, 2022 · 2 comments
Closed

task does not follow directory symlinks when checking for dependencies #826

mbergal opened this issue Aug 3, 2022 · 2 comments
Labels
good first issue Issues that are good for first-time contributors to pick up. type: bug Something not working as intended.

Comments

@mbergal
Copy link

mbergal commented Aug 3, 2022 •
edited
Loading

  • Task version: v3.14.0
  • Operating System: Ubuntu 20.04

Example Taskfile showing the issue

See https://github.com/mbergal/task-symlinks-example

> task 
...
> echo aaa > src/a
...
> task
> echo aaa > src/shared/b
task: Task "default" is up to date
@andreynering andreynering added type: bug Something not working as intended. good first issue Issues that are good for first-time contributors to pick up. labels Aug 4, 2022
@andreynering
Copy link
Member

Hi @mbergal, thanks for reporting!

If anyone is interested, contribution is welcome with this one.

@ilewin
Copy link
Contributor

ilewin commented Aug 4, 2022

I'd like to give it a try.
There is a similar issue in mvdan.cc/sh (shell interpreter used in task)
mvdan/sh#843

ilewin added a commit to ilewin/task that referenced this issue Aug 8, 2022
@ilewin
Issue go-task#826
00273a2
ilewin added a commit to ilewin/task that referenced this issue Aug 10, 2022
@ilewin
go-task#826 fixed glob function
b5a022f
ilewin added a commit to ilewin/task that referenced this issue Aug 12, 2022
@ilewin
Issue go-task#826
98ba3fd 
Changed back sh version to 3.6

Changed back sh version to 3.6

Changed back sh version to 3.6
ilewin added a commit to ilewin/task that referenced this issue Aug 23, 2022
@ilewin
Issue go-task#826. Added ability for the glob func to evaluate symlinks
6e18872
ilewin added a commit to ilewin/task that referenced this issue Aug 23, 2022
@ilewin
Issue go-task#826. Replaced zglob.Glob func with GlobFollowSymlinks t…
2a67499 
…o evaluate symlinks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are good for first-time contributors to pick up. type: bug Something not working as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbergal @andreynering @ilewin