Fix task names for --list and --list-all
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task names should not be overrided by `label`.
pd93
approved these changes
Oct 1, 2022
There was a problem hiding this comment.
I think this is a good change. The linked issue was asking to allow calling tasks by their labels, but I think this is a job for aliases (in a future feature) instead.
Worth noting that this will conflict with #874, but I don't want to discard this contribution, so I feel we should merge this first and I can rebase the other branch later.
|
Thanks @biozz! |
andreynering
added a commit
that referenced
this pull request
Oct 7, 2022
maxpushka
pushed a commit
to maxpushka/task
that referenced
this pull request
Oct 10, 2022
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #603.