Fixed table schema using with SQL Server. #30

ekhabarov · 2018-06-27T13:46:20Z

Hi!

This PR fixes next bug. If you create any table in database in SQL Server within schema different to dbo, for instance x.empty_table_without_fixtures, and run tests you'll get an error

% go test -tags sqlserver -v                                                                
=== RUN   TestFixtureFile                                                                                                                                                                     
--- PASS: TestFixtureFile (0.00s)                                                                                
=== RUN   TestLoadFixtures                                                                                           
Test for mssql                                           
--- FAIL: TestLoadFixtures (0.06s)                      
        testfixtures_test.go:150: Error on loading fixtures: mssql: Cannot find the object "empty_table_without_fixtures" because it does not exist or you do not have permissions.
        testfixtures_test.go:139: posts should have 2, but has 0          
        testfixtures_test.go:139: comments should have 4, but has 0                                           
        testfixtures_test.go:139: tags should have 3, but has 0      
        testfixtures_test.go:139: posts_tags should have 2, but has 0
        testfixtures_test.go:139: users should have 2, but has 0          
        testfixtures_test.go:200: Error on loading fixtures: mssql: Cannot find the object "empty_table_without_fixtures" because it does not exist or you do not have permissions.           
        testfixtures_test.go:139: posts should have 2, but has 1
        testfixtures_test.go:139: comments should have 4, but has 0                                                
        testfixtures_test.go:139: tags should have 3, but has 0                                                                                                                               
        testfixtures_test.go:139: posts_tags should have 2, but has 0                                                                                                                         
        testfixtures_test.go:74: mssql: Invalid object name 'empty_table_without_fixtures'.
        testfixtures_test.go:82: mssql: Cannot find the object "empty_table_without_fixtures" because it does not exist or you do not have permissions.
=== RUN   TestQuoteKeyword                           
--- PASS: TestQuoteKeyword (0.00s)                                                             
=== RUN   TestDatabaseNameHelperSurfacesErrors                                                                                                                                                
Test for mssql                                                                                                                                
--- PASS: TestDatabaseNameHelperSurfacesErrors (0.00s)                                                                                                        
FAIL                                                      
exit status 1                                     
FAIL    github.com/go-testfixtures/testfixtures 0.067s

... because function tableName does not support table schema.

andreynering

Hi @ekhabarov!

Thanks a lot for your PR! A few comments and this is good to go

andreynering · 2018-06-30T23:28:56Z

sqlserver.go

+// Splitter is a BatchSplitter interface implementation. We need it for
+// SQL Server because commands like a `CREATE SCHEMA...` and a `CREATE TABLE...`
+// could not be executed in the same batch.
+// See https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2008-r2/ms175502(v=sql.105)#rules-for-using-batches


Ouch!

I think I should move the schema files to either a function or an YAML file (so arrays are allowed to run multiple statements) to prevent logic like this

But for this PR this is good enough as is, we can do that later

andreynering · 2018-06-30T23:29:55Z

testdata/schema/sqlserver.sql

@@ -18,6 +21,15 @@ CREATE TABLE tags (
 	,created_at DATETIME NOT NULL
 	,updated_at DATETIME NOT NULL
 );
+GO
+
+CREATE SCHEMA x AUTHORIZATION dbo;


Can we rename x to something more descriptive, like non_default_schema?

andreynering · 2018-06-30T23:30:22Z

testdata/schema/sqlserver.sql

+GO
+
+CREATE TABLE x.empty_table_without_fixtures (
+  id INT IDENTITY PRIMARY KEY


Let's keep indentation with tabs for now, to be consistent with the rest of the file

andreynering · 2018-06-30T23:30:53Z

testfixtures_test.go

@@ -52,14 +51,25 @@ func TestLoadFixtures(t *testing.T) {
 			log.Fatalf("Failed to ping database: %v\n", err)
 		}

-		bytes, err = ioutil.ReadFile(database.schemaFile)
+		batches := [][]byte{}


var batches [][]byte

andreynering · 2018-06-30T23:32:09Z

testfixtures_test.go

-		if err != nil {
-			log.Fatalf("Failed to create schema: %v\n", err)
+		h, ok := database.helper.(BatchSplitter)
+		if ok {


if h, ok := database.helper.(BatchSplitter); ok {

andreynering · 2018-06-30T23:32:56Z

testfixtures_test.go

+
+		for _, b := range batches {
+			_, err = db.Exec(string(b))
+			if err != nil {


if _, err = db.Exec(string(b)); err != nil {

andreynering · 2018-06-30T23:34:07Z

helper.go

+// For Microsoft SQL Server batch splitter is "GO". For details see
+// https://docs.microsoft.com/en-us/sql/t-sql/language-elements/sql-server-utilities-statements-go
+type BatchSplitter interface {
+	Splitter() []byte


What about moving the interface and method to lower case? I don't think this need to be exported

ekhabarov · 2018-07-02T17:56:28Z

Hi @andreynering!

Fixed.

andreynering · 2018-07-03T01:10:39Z

@ekhabarov Thanks! 🙂

Fixed table schema using with SQL Server.

9ed8b21

andreynering approved these changes Jun 30, 2018

View reviewed changes

Fixed by review comment.

afc44df

andreynering merged commit 689bce4 into go-testfixtures:master Jul 3, 2018

andreynering mentioned this pull request Jul 3, 2018

Improve tests by somehow allow multiple batches while loading test schema #32

Open

ekhabarov deleted the sqlserver-schema-fix branch July 11, 2023 03:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed table schema using with SQL Server. #30

Fixed table schema using with SQL Server. #30

ekhabarov commented Jun 27, 2018

andreynering left a comment

andreynering Jun 30, 2018

andreynering Jun 30, 2018

andreynering Jun 30, 2018

andreynering Jun 30, 2018

andreynering Jun 30, 2018

andreynering Jun 30, 2018

andreynering Jun 30, 2018

ekhabarov commented Jul 2, 2018

andreynering commented Jul 3, 2018

Fixed table schema using with SQL Server. #30

Fixed table schema using with SQL Server. #30

Conversation

ekhabarov commented Jun 27, 2018

andreynering left a comment

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

andreynering Jun 30, 2018

Choose a reason for hiding this comment

ekhabarov commented Jul 2, 2018

andreynering commented Jul 3, 2018