chore: address review feedback

go-vela · Jun 5, 2023 · d58ba43 · d58ba43
1 parent 2e8028b
commit d58ba43
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/action/schedule/add_test.go b/action/schedule/add_test.go
@@ -107,7 +107,7 @@ func TestSchedule_Config_Add(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("Add for %s returned err: %v", err, test.name)
+				t.Errorf("Add for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/get_test.go b/action/schedule/get_test.go
@@ -19,7 +19,7 @@ func TestSchedule_Config_Get(t *testing.T) {
 	// create a vela client
 	client, err := vela.NewClient(s.URL, "vela", nil)
 	if err != nil {
-		t.Errorf("unable to create tes client: %v", err)
+		t.Errorf("unable to create test client: %v", err)
 	}
 
 	// setup tests
@@ -116,7 +116,7 @@ func TestSchedule_Config_Get(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("Get for %s returned err: %v", err, test.name)
+				t.Errorf("Get for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/remove_test.go b/action/schedule/remove_test.go
@@ -19,7 +19,7 @@ func TestSchedule_Config_Remove(t *testing.T) {
 	// create a vela client
 	client, err := vela.NewClient(s.URL, "vela", nil)
 	if err != nil {
-		t.Errorf("unable to create client: %v", err)
+		t.Errorf("unable to create test client: %v", err)
 	}
 
 	// setup tests
@@ -110,7 +110,7 @@ func TestSchedule_Config_Remove(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("Remove for %s returned err: %v", err, test.name)
+				t.Errorf("Remove for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/table_test.go b/action/schedule/table_test.go
@@ -39,14 +39,14 @@ func TestSchedule_table(t *testing.T) {
 
 			if test.failure {
 				if err == nil {
-					t.Errorf("table should have returned err")
+					t.Errorf("table for %s should have returned err", test.name)
 				}
 
 				return
 			}
 
 			if err != nil {
-				t.Errorf("table returned err: %v", err)
+				t.Errorf("table for %s returned err: %v", test.name, err)
 			}
 		})
 	}
@@ -80,14 +80,14 @@ func TestSchedule_wideTable(t *testing.T) {
 
 			if test.failure {
 				if err == nil {
-					t.Errorf("wideTable should have returned err")
+					t.Errorf("wideTable for %s should have returned err", test.name)
 				}
 
 				return
 			}
 
 			if err != nil {
-				t.Errorf("wideTable returned err: %v", err)
+				t.Errorf("wideTable for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/update_test.go b/action/schedule/update_test.go
@@ -19,7 +19,7 @@ func TestSchedule_Config_Update(t *testing.T) {
 	// create a vela client
 	client, err := vela.NewClient(s.URL, "vela", nil)
 	if err != nil {
-		t.Errorf("unable to create client: %v", err)
+		t.Errorf("unable to create test client: %v", err)
 	}
 
 	// setup tests
@@ -120,7 +120,7 @@ func TestSchedule_Config_Update(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("Update for %s returned err: %v", err, test.name)
+				t.Errorf("Update for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/validate_test.go b/action/schedule/validate_test.go
@@ -133,7 +133,7 @@ func TestSchedule_Config_Validate(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("Validate %s returned err: %v", test.name, err)
+				t.Errorf("Validate for %s returned err: %v", test.name, err)
 			}
 		})
 	}

diff --git a/action/schedule/view_test.go b/action/schedule/view_test.go
@@ -19,7 +19,7 @@ func TestSchedule_Config_View(t *testing.T) {
 	// create a vela client
 	client, err := vela.NewClient(s.URL, "vela", nil)
 	if err != nil {
-		t.Errorf("unable to create client: %v", err)
+		t.Errorf("unable to create test client: %v", err)
 	}
 
 	// setup tests
@@ -110,7 +110,7 @@ func TestSchedule_Config_View(t *testing.T) {
 			}
 
 			if err != nil {
-				t.Errorf("View for %s returned err: %v", err, test.name)
+				t.Errorf("View for %s returned err: %v", test.name, err)
 			}
 		})
 	}