Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): set max template depth and adjust CompileLite call #467

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

ecrupper
Copy link
Contributor

Resolves issue where vela validate pipeline --template --template-file < ... > results in an error due to the template depth not being set in the CLI's compiler instance. Error also exists with vela exec pipeline.

@ecrupper ecrupper requested a review from a team as a code owner July 25, 2023 20:02
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #467 (48cc7af) into main (00b511e) will decrease coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
- Coverage   86.49%   86.41%   -0.09%     
==========================================
  Files         145      145              
  Lines        6288     6300      +12     
==========================================
+ Hits         5439     5444       +5     
- Misses        694      700       +6     
- Partials      155      156       +1     
Files Changed Coverage Δ
command/pipeline/exec.go 0.00% <0.00%> (ø)
command/pipeline/validate.go 72.00% <57.14%> (-0.10%) ⬇️
action/pipeline/validate.go 88.72% <100.00%> (ø)

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider allowing override of template depth only when validating local templates to avoid potential of flooding SCM with template requests

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants