Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update templates for starlark and go #201

Merged
merged 7 commits into from
Jan 28, 2021
Merged

docs: update templates for starlark and go #201

merged 7 commits into from
Jan 28, 2021

Conversation

JordanSussman
Copy link
Collaborator

supersede #185

@JordanSussman JordanSussman requested a review from a team as a code owner January 24, 2021 01:36
@JordanSussman JordanSussman changed the title Templates docs: update templates for starlark and go Jan 24, 2021
kneal
kneal approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal
Copy link
Contributor

kneal commented Jan 28, 2021

@JordanSussman Will close the draft

jbrockopp
jbrockopp approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plyr4 plyr4 merged commit b829e28 into go-vela:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockopp jbrockopp jbrockopp approved these changes

@kneal kneal kneal approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JordanSussman @kneal @jbrockopp @plyr4