Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schedule): nested API + migration to server types #309

Merged
merged 4 commits into from
May 8, 2024

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Apr 29, 2024

Description

Moved Schedule out of go-vela/types and into go-vela/server. Updated imports in CLI to reflect those changes.

Related

go-vela/server#1108

@wsan3 wsan3 added the enhancement Indicates an improvement to a feature label Apr 29, 2024
@wsan3 wsan3 self-assigned this Apr 29, 2024
@wsan3 wsan3 requested a review from a team as a code owner April 29, 2024 18:01
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule.go Show resolved Hide resolved
vela/schedule_test.go Show resolved Hide resolved
vela/schedule_test.go Show resolved Hide resolved
vela/schedule_test.go Show resolved Hide resolved
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.47%. Comparing base (8581ed0) to head (ad408a4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          21       21           
  Lines         817      817           
=======================================
  Hits          731      731           
  Misses         52       52           
  Partials       34       34           
Files Coverage Δ
vela/schedule.go 71.42% <75.00%> (ø)

@wsan3 wsan3 merged commit 1cd2e5c into main May 8, 2024
10 of 11 checks passed
@wsan3 wsan3 deleted the feat/show-schedule-errors branch May 8, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants