Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(repo/secret): differentiate PRs from contributors vs forks #727

Closed
wants to merge 1 commit into from

Conversation

ecrupper
Copy link
Contributor

Requires go-vela/types#271

Differentiating PRs from contributors and PRs from forks. See types PR for more information.

Also including secret event validation in the API. We currently validate in the UI (limiting to checkboxes) and the CLI, but not direct calls to the API.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #727 (406d3e4) into main (1cc1eab) will decrease coverage by 0.10%.
The diff coverage is 10.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   54.97%   54.87%   -0.11%     
==========================================
  Files         211      211              
  Lines       16021    16061      +40     
==========================================
+ Hits         8808     8813       +5     
- Misses       6836     6871      +35     
  Partials      377      377              
Impacted Files Coverage Δ
api/build.go 1.64% <0.00%> (ø)
api/repo.go 0.00% <0.00%> (ø)
api/secret.go 0.00% <0.00%> (ø)
api/webhook.go 0.00% <0.00%> (ø)
database/repo/table.go 100.00% <ø> (ø)
compiler/native/compile.go 62.34% <100.00%> (+0.09%) ⬆️
scm/github/webhook.go 86.20% <100.00%> (+0.13%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant