Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check for origin and name #181

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: add check for origin and name #181

merged 1 commit into from
Jun 8, 2021

Conversation

kneal
Copy link

@kneal kneal commented Jun 8, 2021

No description provided.

@kneal kneal self-assigned this Jun 8, 2021
@kneal kneal requested a review from a team as a code owner June 8, 2021 17:26
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #181 (3c19692) into master (bbd070b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files          53       53           
  Lines        3274     3274           
=======================================
  Hits         3173     3173           
  Misses         56       56           
  Partials       45       45           
Impacted Files Coverage Δ
yaml/secret.go 94.73% <100.00%> (ø)

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrockopp jbrockopp merged commit 8396842 into master Jun 8, 2021
@jbrockopp jbrockopp deleted the fix/secret/origin branch June 8, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants