-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hook): add hook id to hook object #239
Conversation
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 97.16% 97.17% +0.01%
==========================================
Files 54 54
Lines 5828 5850 +22
==========================================
+ Hits 5663 5685 +22
Misses 122 122
Partials 43 43
|
I'm thinking |
i agree with sussman on |
although i see the scenario for |
some options, not all of them good
|
i kind of like edit: i like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Couple related issues: go-vela/community#459 and go-vela/community#416
The
hook_id
is the field needed from GitHub to not only reach that deliveries page but also interact with any of their API endpoints related to hook deliveries. Ahook_id
is unique to any one hook within a repo, but since we already have anid
field as well as arepo_id
field, I choseaddress
as the name. If anyone has a suggestion for another name, I am all ears!I also cleaned up a couple of typos I noticed in the comments of
build.go