-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Hash field to repo type #37
Conversation
@@ -78,6 +81,9 @@ func TestLibrary_Repo_Getters(t *testing.T) { | |||
if gotUserID != wantUserID { | |||
t.Errorf("GetUserID is %v, want %v", gotUserID, wantUserID) | |||
} | |||
if gotHash != wantHash { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if statements should only be cuddled with assignments (from wsl
)
@@ -154,6 +161,9 @@ func TestLibrary_Repo_Getters_Empty(t *testing.T) { | |||
if gotUserID != 0 { | |||
t.Errorf("GetUserID is %v, want 0", gotUserID) | |||
} | |||
if gotHash != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if statements should only be cuddled with assignments (from wsl
)
@@ -252,6 +264,9 @@ func TestLibrary_Repo_Setters(t *testing.T) { | |||
if r.GetUserID() != wantUserID { | |||
t.Errorf("GetUserID is %v, want %v", r.GetUserID(), wantUserID) | |||
} | |||
if r.GetHash() != wantHash { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if statements should only be cuddled with assignments (from wsl
)
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 40
Lines 2213 2227 +14
=====================================
+ Hits 2213 2227 +14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.