Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add exec method for delete #19

Merged
merged 1 commit into from
Jan 14, 2020
Merged

feat: add exec method for delete #19

merged 1 commit into from
Jan 14, 2020

Conversation

jbrockopp
Copy link
Contributor

No description provided.

@jbrockopp jbrockopp added the feature Indicates a new feature label Jan 14, 2020
@jbrockopp jbrockopp requested a review from a team as a code owner January 14, 2020 17:22
@jbrockopp jbrockopp self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #19 into master will increase coverage by 1.01%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   34.97%   35.99%   +1.01%     
==========================================
  Files          14       14              
  Lines         426      439      +13     
==========================================
+ Hits          149      158       +9     
- Misses        272      276       +4     
  Partials        5        5
Impacted Files Coverage Δ
cmd/vela-artifactory/delete.go 77.77% <69.23%> (-22.23%) ⬇️

KellyMerrick
KellyMerrick approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

plyr4
plyr4 approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 4199104 into master Jan 14, 2020
@plyr4 plyr4 deleted the delete/exec branch January 14, 2020 21:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@plyr4 plyr4 plyr4 approved these changes

Assignees

@jbrockopp jbrockopp

Labels
feature Indicates a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockopp @KellyMerrick @plyr4