Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support map type for build args #194

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 9, 2024

These changes will allow the following pipeline:

steps:
  - name: kaniko
    image: target/vela-kaniko:latest
    parameters:
      build_args:
        list: one,two,three
        foo: bar
      dry_run: true
      registry: docker.company.com
      repo: docker.company.com/myapp

Today, if using the slice input, the above would interpret the build args as --build-arg list=one --build-arg two --build-arg three --build-arg foo=bar.

@ecrupper ecrupper requested a review from a team as a code owner May 9, 2024 17:29
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 34.88%. Comparing base (abe96d6) to head (51374e0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   35.55%   34.88%   -0.67%     
==========================================
  Files           7        7              
  Lines         526      536      +10     
==========================================
  Hits          187      187              
- Misses        339      349      +10     
Files Coverage Δ
cmd/vela-kaniko/main.go 0.00% <0.00%> (ø)

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for maintaining backwards compatibility

@ecrupper ecrupper merged commit 5ff72b3 into main May 9, 2024
8 of 12 checks passed
@ecrupper ecrupper deleted the enhance/build-args-map branch May 9, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants