fix(deps): update module github.com/go-vela/types to v0.23.2 [security]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
github.com/go-vela/types	v0.22.0 -> v0.23.2

GitHub Vulnerability Alerts

GHSA-7v38-w32m-wx4m

Impact

Vela pipelines can use variable substitution combined with insensitive fields like parameters, image and entrypoint to inject secrets into a plugin/image and — by using common substitution string manipulation — can bypass log masking and expose secrets without the use of the commands block. This unexpected behavior primarily impacts secrets restricted by the "no commands" option. This can lead to unintended use of the secret value, and increased risk of exposing the secret during image execution bypassing log masking.

Given by the following substitution examples:
using parameters

steps:
  - name: example
    image: <some plugin>
    secrets: [ example_secret ]
    parameters:
      example: $${EXAMPLE_SECRET}

using image tag

steps:
  - name: example
    image: <some plugin>:latest${EXAMPLE_SECRET}
    secrets: [ example_secret ]

using entrypoint as a shim for commands

steps:
  - name: example
    image: <some plugin>
    secrets: [ example_secret ]
    entrypoint:
      [
        "sh",
        "-c",
        "echo $EXAMPLE_SECRET",
      ]

To exploit this the pipeline author must be supplying the secrets to a plugin that is designed in such a way that will print those parameters in logs. Plugin parameters are not designed for sensitive values and are often intentionally printed throughout execution for informational/debugging purposes. Parameters should therefore be treated as insensitive.

While Vela provides secrets masking, secrets exposure is not entirely solved by the masking process. A docker image (plugin) can easily expose secrets if they are not handled properly, or altered in some way. There is a responsibility on the end-user to understand how values injected into a plugin are used. This is a risk that exists for many CICD systems (like GitHub Actions) that handle sensitive runtime variables. Rather, the greater risk is that users who restrict a secret to the "no commands" option and use image restriction can still have their secret value exposed via substitution tinkering, which turns the image and command restrictions into a false sense of security.

Patches

N/A

Workarounds

• Do not provide sensitive values to plugins that can potentially expose them, especially in parameters that are not intended to be used for sensitive values.
• Ensure plugins (especially those that utilize shared secrets) follow best practices to avoid logging parameters that are expected to be sensitive.
• Minimize secrets with pull_request events enabled, as this allows users to change pipeline configurations and pull in secrets to steps not typically part of the CI process.
• Make use of the build approval setting, restricting builds from untrusted users
• Limit use of shared secrets, as they are less restrictive to access by nature.

References

• https://github.com/go-vela/worker

For more information

If you have any questions or comments about this advisory:

• Email us at vela@target.com

Affected products: go-vela/worker

---

Release Notes

go-vela/types (github.com/go-vela/types)

v0.23.2

Compare Source

What's Changed

• chore(deps): update all non-major dependencies by @​renovate in https://github.com/go-vela/types/pull/359

Full Changelog: go-vela/types@v0.23.1...v0.23.2

v0.23.1

Compare Source

What's Changed

• chore(deps): update github/codeql-action action to v3.24.5 by @​renovate in https://github.com/go-vela/types/pull/358

Full Changelog: go-vela/types@v0.23.0...v0.23.1

v0.23.0

Compare Source

What's Changed

• feat(repo settings): approve build mechanism for pull_request events by @​ecrupper in https://github.com/go-vela/types/pull/328
• feat(repo)!: change allow_<event> fields to an AllowEvents struct + DB use integer masking by @​ecrupper in https://github.com/go-vela/types/pull/314
• fix(repo_events): add support for reopen by @​ecrupper in https://github.com/go-vela/types/pull/337
• feat(deployment): add deployment table by @​claire1618 in https://github.com/go-vela/types/pull/323
• enhance(secret): use allow event system by @​ecrupper in https://github.com/go-vela/types/pull/341
• feat: adding a delete_event by @​claire1618 in https://github.com/go-vela/types/pull/340
• fix: enabling a delete event to be allowed by @​claire1618 in https://github.com/go-vela/types/pull/342
• fix(repo): remove dead code EventAllowed by @​ecrupper in https://github.com/go-vela/types/pull/343
• enhance(ci): include PR title validation workflow by @​ecrupper in https://github.com/go-vela/types/pull/344
• fix(events): add schedule to ToDatabase and improve tests by @​ecrupper in https://github.com/go-vela/types/pull/345
• enhance(env): add VELA_PULL_REQUEST_SOURCE and _TARGET to comment type by @​ecrupper in https://github.com/go-vela/types/pull/346
• fix: title validator handle no parentheses + enforce whitespace by @​ecrupper in https://github.com/go-vela/types/pull/347
• feat: remodling EventDelete to resemble EventTag by @​claire1618 in https://github.com/go-vela/types/pull/348
• chore(deps): bulk update deps by @​ecrupper in https://github.com/go-vela/types/pull/349
• chore(deps): update codecov/codecov-action action to v4 by @​renovate in https://github.com/go-vela/types/pull/350
• chore(deps): update all non-major dependencies by @​renovate in https://github.com/go-vela/types/pull/334
• fix: fixing Nullify() DeployNumber statment to actually work by @​claire1618 in https://github.com/go-vela/types/pull/351
• chore(deps): update all non-major dependencies by @​renovate in https://github.com/go-vela/types/pull/352
• fix(schema): add delete events and wildcard to pull_request by @​ecrupper in https://github.com/go-vela/types/pull/354
• fix(database): add limit and eviction policy for deployment builds by @​ecrupper in https://github.com/go-vela/types/pull/355
• fix(ci): codeql by @​wass3rw3rk in https://github.com/go-vela/types/pull/356
• chore(deps): update github/codeql-action digest to e8893c5 by @​renovate in https://github.com/go-vela/types/pull/353
• chore(ci): include minor and patch versions in workflows by @​ecrupper in https://github.com/go-vela/types/pull/357

Full Changelog: go-vela/types@v0.22.0...v0.23.0

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.38%. Comparing base (a04c0e3) to head (1ab0c11).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   15.38%   15.38%           
=======================================
  Files           7        7           
  Lines         663      663           
=======================================
  Hits          102      102           
  Misses        558      558           
  Partials        3        3           

[KellyMerrick]

lgtm