Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Fix exporting values into Postgres #1186

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

gzsombor
Copy link
Contributor

@gzsombor gzsombor commented Jan 9, 2019

Fixing go-gitea/gitea#5651

  • UUID and BOOL type shouldn't have a length field
  • Incorrect quoting cause that the column names are selected instead of the column values

 * UUID and BOOL type shouldn't have a length field
 * Incorrect quoting cause that the column names are selected instead of the column values
@codecov-io
Copy link

Codecov Report

Merging #1186 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   54.69%   54.69%   +<.01%     
==========================================
  Files          42       42              
  Lines        7646     7649       +3     
==========================================
+ Hits         4182     4184       +2     
- Misses       2935     2936       +1     
  Partials      529      529
Impacted Files Coverage Δ
engine.go 61.52% <0%> (-0.07%) ⬇️
dialect_postgres.go 75.72% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f0a71...b255dcb. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #1186 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
+ Coverage   54.69%   54.69%   +<.01%     
==========================================
  Files          42       42              
  Lines        7646     7649       +3     
==========================================
+ Hits         4182     4184       +2     
- Misses       2935     2936       +1     
  Partials      529      529
Impacted Files Coverage Δ
engine.go 61.52% <0%> (-0.07%) ⬇️
dialect_postgres.go 75.72% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f0a71...b255dcb. Read the comment docs.

@lunny lunny merged commit 1cd2662 into go-xorm:master Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants