Feature Request (with code to do it!) OmitEmpty on structures

[rabarar]

if a structure has the yam:key,omitempty tag, why not omit it as well if it's members are all empty:

To do so, simply add the following snippet to isZero in yaml.go - where we check for a structure and then recursively call isZero on all of it's members...

case reflect.Struct:
for i := 0; i < v.NumField(); i++ {
p := v.Field(i)
if !isZero(p) {
return false
}
}
return true

[niemeyer]

The code isn't right, but the idea is fine.

[rabarar]

Why isn't it right - it worked when I added it?

On Nov 14, 2014, at 4:29 AM, Gustavo Niemeyer notifications@github.com wrote:

The code isn't right, but the idea is fine.

—
Reply to this email directly or view it on GitHub.

[rabarar]

And I should have said it earlier, thanks for sharing yaml! It's great stuff!!

On Nov 14, 2014, at 4:29 AM, Gustavo Niemeyer notifications@github.com wrote:

The code isn't right, but the idea is fine.

—
Reply to this email directly or view it on GitHub.

[niemeyer]

The problem in the sample code is that only fields that are exported should be considered. I have the same logic working in the mgo/bson parser and will copy it over.

[rabarar]

Thanks

On Jan 16, 2015, at 1:46 PM, Gustavo Niemeyer notifications@github.com wrote:

Closed #54 via 26b8825.

—
Reply to this email directly or view it on GitHub.