Concurrent map read and map write under Go 1.6.0

[solher]

Since Go 1.6.0 and the concurrent acces detector, my app crashes under heavy load:

fatal error: concurrent map read and map write

at github.com/go-zoo/bone/route.go:98

Does anybody else is experiencing the same issue ?

[haoxins]

map vars has been deleted In the branch beta https://github.com/go-zoo/bone/tree/beta, 11ebbcb.

[solher]

Ok cool ;)

[solher]

New error, even in the branch beta.
I got a fatal error: concurrent map writes on the muxStack[req] = m in ServeHTTP.

func (m *Mux) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
    muxStack[req] = m
    // Check if a route match
    if !m.parse(rw, req) {
        // Check if it's a static ressource
        if !m.staticRoute(rw, req) {
            // Check if the request path doesn't end with /
            if !m.validate(rw, req) {
                m.HandleNotFound(rw, req)
            }
        }
    }
    delete(muxStack, req)
}

[squiidz]

I'm already working on this :) should be fix tomorrow. I'ts a litlle bit long, because i'm trying to find a way to drop the delay of route containing variables. Any ideas are welcome !

[solher]

Hahaha awesome :)

[solher]

It seems that it is still not working.
I still got some fatal error: concurrent map writes at the same place.

Any plans ? Because half of my services crash right now.

[squiidz]

It should be done tomorrow, I will notify you when it's ok. Sorry for the delay

[solher]

No problem, thanks 👍

[squiidz]

it should work on the beta branch now.

[solher]

Thanks a lot ;)