Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow abstract.com domain for share links and expose inferShareId #217

Merged
merged 2 commits into from
Feb 16, 2020

Conversation

anthony-j-castro
Copy link
Contributor

Share links with the abstract.com domain should be considered valid. This PR updates the parseShareURL function to allow this domain.

I made a similar update in amccloud/storybook-addons-abstract#6. In that PR, @amccloud made the suggestion that we expose inferShareId since he manually copied it into the package, so I've also done that in this PR 🙂

Copy link
Contributor

@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anthony-j-castro anthony-j-castro merged commit 7789a92 into master Feb 16, 2020
@anthony-j-castro anthony-j-castro deleted the fix/share-link-domain branch February 16, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants