fix: Remove references to cloning weather sample with gonew #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK makes sense. Maybe we should make the example its own module and define a go workspace at the top level of the repo. I'll work on that. |
|
done: goadesign/clue#312 |
ikawaha
added a commit
to ikawaha/examples
that referenced
this pull request
Oct 25, 2023
…oadesign#139)" This reverts commit aab0827.
raphael
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:#131
I apologize for the oversight in the previous PR d9ffbdc. It turns out that the weather example from the clue repository cannot be cloned using the gonew command. The reason is that the weather example consists of multiple services and is not structured as a single module. Since gonew is designed to clone a single module as a template, it cannot target the weather example.