Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle Number default values defined as int. #1344

Merged
merged 1 commit into from Aug 8, 2017

Conversation

@raphael
Copy link
Member

@raphael raphael commented Aug 8, 2017

So that this is legal:

Param("num", Number, func() {
    Default(50)
})

Fix #1342

So that this is legal:

    Param("num", Number, func() {
        Default(50)
    })
@raphael raphael force-pushed the v1.allow_number_int_default_values branch from d70e10b to 374e439 Aug 8, 2017
@raphael raphael merged commit 2ec66db into v1 Aug 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@raphael raphael deleted the v1.allow_number_int_default_values branch Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant