-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: Fix trailing slash in routing removed #2530
Conversation
Great, thank you! Can you please also back-port to v2, thanks! |
* Fix trailing slash in routing removed * Exclude when the path is the root * Fix a test
* v3: Fix trailing slash in routing removed (#2530) * Fix trailing slash in routing removed * Exclude when the path is the root * Fix a test * Fix import paths
Is the handling here different for POST requests? I'm seeing My design is:
but I'm seeing:
(where the 405 indicates that the GET call to that path is invalid). I tried updating to the latest commit using |
Just confirmed that if I add the trailing slash back into Did I fail to update to the right version, or is this bug still open for POST requests? |
Oops. I think I was forgetting to rerun generate. Once I did that, I think we're back online. Thanks for the fix and sorry for the false alarm! |
The routing trailing slash problem fixed in v1 seems to be occurring again in v3.
This patch fixes it in the same way as v1.
see also. #1283