pkg:path types that reference their own package types #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a user type placed in a package, ie. common, and it has a field of another type in package common, we codegen a type reference of common.Thing which will fail, as that code is already in the common package.
|
@raphael this is a failing test for what we were discussing in Slack! |
with attributes that themselves use the custom package path.
|
Linking here for those that find it: https://gophers.slack.com/archives/C0FK8EV28/p1656434471212069?thread_ts=1655929395.006179&cid=C0FK8EV28 tl;dr, this PR did not achieve what it needs to, and you'll still get redundant package prefixes to types into an external package. |
ernesto-jimenez
pushed a commit
to ernesto-jimenez/goa
that referenced
this pull request
Jun 28, 2022
…pkg:path` What was the issue? What was meant to be a check on the parentPkg to avoid recursive definitions wasn't actually checking the parent package, but the package of the field itself. It was a bug that got introduced in goadesign#3022 and never worked as expected. Solution: Injecting the parent package for the initial definition seems to address this.
raphael
pushed a commit
that referenced
this pull request
Jul 12, 2022
What was the issue? What was meant to be a check on the parentPkg to avoid recursive definitions wasn't actually checking the parent package, but the package of the field itself. It was a bug that got introduced in #3022 and never worked as expected. Solution: Injecting the parent package for the initial definition seems to address this.
raphael
added a commit
that referenced
this pull request
Jul 12, 2022
…#3084) * Fixes #3083: properly generate attributes with meta `struct:pkg:path` What was the issue? What was meant to be a check on the parentPkg to avoid recursive definitions wasn't actually checking the parent package, but the package of the field itself. It was a bug that got introduced in #3022 and never worked as expected. Solution: Injecting the parent package for the initial definition seems to address this. * Update codegen/scope.go * failing server encoding test * Fix marshalling function argument type packages When using "struct:pkg:path" Co-authored-by: Raphael Simon <simon.raphael@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a user type placed in a package, ie. common, and it has a
field of another type in package common, we codegen a type reference of
common.Thing which will fail, as that code is already in the common
package.