Fixes #3083: properly generate attributes with meta struct:pkg:path
#3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pkg:path` What was the issue? What was meant to be a check on the parentPkg to avoid recursive definitions wasn't actually checking the parent package, but the package of the field itself. It was a bug that got introduced in goadesign#3022 and never worked as expected. Solution: Injecting the parent package for the initial definition seems to address this.
ernesto-jimenez
commented
Jun 28, 2022
|
@raphael this fixes part of the issue in #3083 The
Instead of using the type from Any suggestions on how to address the second part? |
during marshaling/unmarshaling
|
Thank you for this, will take a look |
|
@raphael I have added a failing test to illustrate the remaining issue. I reckon the issue might be with |
* Upgrade to Go 1.18 * Use Go 1.18 in CI * sudo does not exist on Windows
The prior code didn't always take into consideration the case where a type has a required validation that does not apply (e.g. object with only primitive types that are not pointers). This refactor moves the logic to a common method that handles all corner cases.
…pkg:path` What was the issue? What was meant to be a check on the parentPkg to avoid recursive definitions wasn't actually checking the parent package, but the package of the field itself. It was a bug that got introduced in goadesign#3022 and never worked as expected. Solution: Injecting the parent package for the initial definition seems to address this.
When using "struct:pkg:path"
…z/goa into fix-struct-pkg-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
What was meant to be a check on the parentPkg to avoid recursive
definitions wasn't actually checking the parent package, but the package
of the field itself.
It was a bug that got introduced in #3022 and never worked as expected.
Solution:
Injecting the parent package for the initial definition seems to address
this.