Add CookieSameSite DSL #3401
Merged
Add CookieSameSite DSL #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredLunde
commented
Oct 22, 2023
http/codegen/server.go
Outdated
| @@ -1352,6 +1352,9 @@ const responseT = `{{ define "response" -}} | |||
| {{- if .HTTPOnly }} | |||
| HttpOnly: true, | |||
| {{- end }} | |||
| {{- if .SameSite }} | |||
| SameSite: {{ printf "%q" .SameSite }}, | |||
There was a problem hiding this comment.
Will these generated lines print the enum from the net/http package e.g. http.SameSiteLaxMode? It just occurred to me that this could be a problem, as http.SameSite___ are iotas.
There was a problem hiding this comment.
Actually there are a couple of issues with this including the "%q" 😅 Will fix. Where can I add tests for the codegen piece?
|
Looks great, thank you! |
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the SameSite cookie attribute available in
net/httpsince Go 1.11.I think this covers everything, but let me know if there's anything else I can/need to do.