Merge pull request #1786 from goalgorilla/bugfix/3123861

Issue #3123861 by Kingdutch: Image label is visible on basic page tea…

config/optional/core.entity_view_display.node.book.teaser.yml

@@ -23,7 +23,7 @@ content:
   field_book_image:
     type: image
     weight: 0
-    label: above
+    label: hidden
     settings:
       image_style: social_x_large
       image_link: content

modules/social_features/social_book/config/update/social_book_update_8802.yml

@@ -0,0 +1,20 @@
+core.entity_view_display.node.book.teaser:
+  expected_config:
+    content:
+      field_book_image:
+        label: above
+  update_actions:
+    change:
+      content:
+        field_book_image:
+          label: hidden
+core.entity_view_display.node.book.hero:
+  expected_config:
+    content:
+      field_book_image:
+        label: above
+  update_actions:
+    change:
+      content:
+        field_book_image:
+          label: hidden

modules/social_features/social_book/social_book.install

@@ -28,6 +28,12 @@ function social_book_update_dependencies() {
     'social_core' => 8802,
   ];
 
+  // Ensure update helper dependant hooks run after update helper
+  // is enabled.
+  $dependencies['social_book'][8802] = [
+    'social_core' => 8805,
+  ];
+
   return $dependencies;
 }
 
@@ -147,3 +153,17 @@ function social_book_update_8801() {
     }
   }
 }
+
+/**
+ * Hide image label in teasers.
+ */
+function social_book_update_8802() {
+  /** @var \Drupal\update_helper\Updater $updateHelper */
+  $updateHelper = \Drupal::service('update_helper.updater');
+
+  // Execute configuration update definitions with logging of success.
+  $updateHelper->executeUpdate('social_book', 'social_book_update_8802');
+
+  // Output logged messages to related channel of update execution.
+  return $updateHelper->logger()->output();
+}

modules/social_features/social_page/config/install/core.entity_view_display.node.page.teaser.yml

@@ -14,8 +14,6 @@ dependencies:
     - image
     - options
     - user
-_core:
-  default_config_hash: 9sTjSemSHaUnHQeBsGy479G03O1t-_i_tHF7IHFPEO0
 id: node.page.teaser
 targetEntityType: node
 bundle: page
@@ -31,7 +29,7 @@ content:
   field_page_image:
     type: image
     weight: 0
-    label: above
+    label: hidden
     settings:
       image_style: social_x_large
       image_link: content

modules/social_features/social_page/config/update/social_page_update_8002.yml

@@ -0,0 +1,10 @@
+core.entity_view_display.node.page.teaser:
+  expected_config:
+    content:
+      field_page_image:
+        label: above
+  update_actions:
+    change:
+      content:
+        field_page_image:
+          label: hidden

modules/social_features/social_page/social_page.install

@@ -103,3 +103,17 @@ function social_page_update_8001() {
   // Output logged messages to related channel of update execution.
   return $updateHelper->logger()->output();
 }
+
+/**
+ * Hide image label in teasers.
+ */
+function social_page_update_8002() {
+  /** @var \Drupal\update_helper\Updater $updateHelper */
+  $updateHelper = \Drupal::service('update_helper.updater');
+
+  // Execute configuration update definitions with logging of success.
+  $updateHelper->executeUpdate('social_page', 'social_page_update_8002');
+
+  // Output logged messages to related channel of update execution.
+  return $updateHelper->logger()->output();
+}