Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3123861 by Kingdutch: Image label is visible on basic page tea… #1786

Merged
merged 4 commits into from Jun 23, 2020

Conversation

Kingdutch
Copy link
Member

@Kingdutch Kingdutch commented Mar 31, 2020

…sers

Problem

The view configuration shows the label for the image of basic pages and book pages in teasers and heros.

Solution

Update the view configuration

Issue tracker

https://www.drupal.org/project/social/issues/3123861

How to test

  • View a basic page in the search results
  • Create (with hero image) and view the detail page of a book page.

Screenshots

If this Pull Request makes visual changes then please include some screenshots that show what has changed here.

Release notes

The label for the image field is no longer visible in teasers for basic pages.

@Kingdutch Kingdutch added type: bug Fixes a bug in Open Social status: needs review This pull request is waiting for a requested review backport: needed This pull request requires a backport to an additionally supported minor version prio: medium team: shipsters labels Mar 31, 2020
@Kingdutch Kingdutch added this to the 8.3 milestone Mar 31, 2020
@robertragas robertragas self-requested a review April 14, 2020 14:28
Copy link
Contributor

@robertragas robertragas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the part from Alexander for the basic pages.

@robertragas
Copy link
Contributor

I have updated this PR with additional setting changes for the social_book which had the same problem.

@ronaldtebrake
Copy link
Contributor

Ensure update_helper module is enabled by adding dependencies to social_core 8805 (for those sites that come from a very old version and might skip numbers it's very important :) )

@ronaldtebrake ronaldtebrake added status: needs work This pull request needs more work before it's ready for review and removed status: needs review This pull request is waiting for a requested review labels Apr 14, 2020
@Kingdutch
Copy link
Member Author

Declared the dependency for social_book_8802. social_page_8801 already had a dependency on social_core_8805 so this isn't needed for social_page_8802

@Kingdutch Kingdutch removed the status: needs work This pull request needs more work before it's ready for review label Apr 28, 2020
@ronaldtebrake ronaldtebrake modified the milestones: 8.3, 8.4 Apr 29, 2020
Not sure where that came from *shrug emoji*
@ronaldtebrake ronaldtebrake merged commit 7073e08 into 8.x-9.x Jun 23, 2020
@ronaldtebrake ronaldtebrake deleted the bugfix/3123861 branch June 23, 2020 06:34
@ronaldtebrake
Copy link
Contributor

Travis was failing due to still testing old core version. Will update this in a separate branch. Manual tests and green checks before made me decide to accept it.

@ronaldtebrake ronaldtebrake added backport: verified This pull request has been back ported to an older minor version and removed backport: needed This pull request requires a backport to an additionally supported minor version labels Jun 23, 2020
@ronaldtebrake
Copy link
Contributor

Also cherry-picked to 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: verified This pull request has been back ported to an older minor version prio: medium type: bug Fixes a bug in Open Social
3 participants