Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3004858 by truls1502: Update csv_serialization 1.3 to 1.4 #1046

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

truls1502
Copy link
Contributor

@truls1502 truls1502 commented Oct 6, 2018

Problem & Solution

Difference between the versions is 2 bug fixes.

  • #2975802: Undefined offset: 0 in Drupal\csv_serialization\Encoder\CsvEncoder->extractHeaders()
  • #2980321: README configs and useful links

Issue tracker

HTT

  • Check out the code changes
  • Check the release notes of the csv_serialization update
  • Check if composer.json and drupal make files have the same versions and patches
  • Verify export functionality (social_user_export) on admin/people still works as expected.

Release notes

Updated csv_serialization 1.3 to 1.4.

@jaapjan jaapjan added this to the 3.3 milestone Oct 15, 2018
@jaapjan jaapjan self-assigned this Oct 15, 2018
@jaapjan
Copy link
Contributor

jaapjan commented Oct 15, 2018

Hi @truls1502 thanks for creating the pullrequest and outlining the difference between the versions!

I've added a how to test to make the review a bit easier. In addition it is still needed to make one change:
The version in drupal-org.make:17 needs to be the same as the one in the composer.json. The .make files are used for packaging Open Social on drupal.org.

@jaapjan jaapjan added status: needs work This pull request needs more work before it's ready for review update labels Oct 15, 2018
@jaapjan
Copy link
Contributor

jaapjan commented Oct 19, 2018

I will merge this one already since it works well. Will change .make file in the merged branch.

@jaapjan jaapjan removed the status: needs work This pull request needs more work before it's ready for review label Oct 19, 2018
@jaapjan jaapjan merged commit e270cc4 into goalgorilla:8.x-3.x Oct 19, 2018
jaapjan added a commit that referenced this pull request Oct 19, 2018
@truls1502
Copy link
Contributor Author

Thank you @jaapjan and sorry for my radio silence.
I have been sick last week and a lot to catch up this week. However, I know I need to modify make and checking against to feature-tests. However, I have put these issues on hold until I solve the issue #1055 because I want to use the Travis test on locally to test and make the contribution better instead of push many small changes ;)

@jaapjan
Copy link
Contributor

jaapjan commented Oct 19, 2018

No problem @truls1502 happy with your contributions already!

@truls1502 truls1502 deleted the fix/csv_serialization branch October 26, 2018 10:49
fmann pushed a commit to fmann/open_social that referenced this pull request Jan 25, 2020
@Kingdutch Kingdutch added type: dependencies Updating a dependency file and removed type: update labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Updating a dependency file
Development

Successfully merging this pull request may close these issues.

3 participants