Internal: Create a new format Simple HTML and enable it for Posts

[T2L]

Problem

At the moment when adding a new post plain text format is enforced, which limits users a lot.

Solution

This PR adds a new filter format: Simple HTML and enables it for posts.

Issue tracker

• https://getopensocial.atlassian.net/browse/SSD-42

Theme issue tracker

N/A

How to test

• Adding a post form now features CKEditor
• CKEditor must include: Bold/Italics; Link/Unlink; Ordered/Unordered lists
• Simple HTML must support mentions
• Enable Social Embed module: Simple HTML must include the embed button
• Editor must be available for all authenticated users

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

Not yet

Change Record

Not yet

Translations

N/A

[mergeable]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. 😊

[navneet0693]

@T2L Please rebase your PR.

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-8qlkdeetgdtndjgxovxgeujajhehzb3j.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/62e8b3357e6c3f16da8e9673

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3015-h6op2doxz5to6qyu3tskuekrjokfzaws.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/63989d5ce2e14d36b53779e3

[BiaInacio]

I was testing this issue and the basic CKEditor on posts is working fine, but when I try to install the Social Embed module the site crashes and the following error is logged on report logs:

[Kingdutch]

Closing the PR since it hasn't seen code activity in some time (sorry Bia!) and I think there are some fundamental problems with the approach that are not explained in the PR or the attached issue.

We have some code specific to text formats which can be problematic as some of the changes show. Adding a new text format is quite a can of worms.

We're also introducing a new way of text editing for users but we're not doing anything to think about how this provides a consistent UX across different input methods for our users. We already have a Restricted HTML input format but it's not documented why that is not sufficient for posts.

[dianahub]

i found if i modify this line : // Allowed formats.
$allowed_format = 'simple_text'; in social_editor.module to $allowed_format = 'restricted_html' and also make sure the restricted html format has a ckeditor configured to it, i get a wysiwig not only on posts but on comments as well.